[#6335] fix(python-client): Fix pypi document link error #6342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jerryshao @xunliu PTAL |
xunliu
reviewed
Jan 22, 2025
| @@ -122,7 +124,7 @@ fun generatePypiProjectHomePage() { | |||
| // relative path of the images in the how-to-use-python-client.md file is incorrect. We need | |||
| // to fix the relative path of the images/markdown to the absolute path. | |||
| val content = outputFile.readText() | |||
| val docsUrl = "https://datastrato.ai/docs/latest" | |||
| val docsUrl = "https://gravitino.apache.org/docs/$gravitinoVersion" | |||
There was a problem hiding this comment.
Please change to
val docsUrl = "https://gravitino.apache.org/docs/latest"
There was a problem hiding this comment.
If using latest, all release pypi document will link to the latest Gravitino document page, is it expected?
github-actions bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
### What changes were proposed in this pull request? Correct the Gravitino document link from `https://datastrato.ai/docs/latest` to `https://gravitino.apache.org/docs/$gravitinoVersion`, suppose the publish version is `0.8.0-incubating`, the link will start with `https://gravitino.apache.org/docs/0.8.0-incubating` ### Why are the changes needed? Fix: #6335 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? run `./gradlew :clients:client-python:distribution -x test` and check `README`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Correct the Gravitino document link from
https://datastrato.ai/docs/latesttohttps://gravitino.apache.org/docs/latest, suppose the publish version is0.8.0-incubating, the link will start withhttps://gravitino.apache.org/docs/latestWhy are the changes needed?
Fix: #6335
Does this PR introduce any user-facing change?
no
How was this patch tested?
run
./gradlew :clients:client-python:distribution -x testand checkREADME